Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test template sync using proxy #16879

Merged
merged 9 commits into from
Jan 6, 2025
Merged

Test template sync using proxy #16879

merged 9 commits into from
Jan 6, 2025

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Nov 6, 2024

Tests for of SAT-27349.

UI part requires SatelliteQE/airgun#1621

Draft because it contains a workaround for discovered regressions and because the feature hasn't been merged yet.

@lhellebr lhellebr changed the title Template sync proxy UI Template sync proxy Nov 6, 2024
@lhellebr lhellebr mentioned this pull request Nov 6, 2024
Closed
@lhellebr lhellebr changed the title Template sync proxy Test template sync using proxy Nov 6, 2024
@lhellebr lhellebr added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 6, 2024
@lhellebr
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@lhellebr lhellebr marked this pull request as ready for review November 11, 2024 16:08
@lhellebr lhellebr requested review from a team as code owners November 11, 2024 16:08
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9325
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ====== 8 failed, 4 passed, 16 skipped, 180 warnings in 2224.96s (0:37:04) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 11, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Nov 11, 2024 •
edited
Loading

PRT results as expected. Tests where proxy is used fail. Tests where it is not used pass. I expect everything to start passing once PR theforeman/foreman_templates#191 is merged in Foreman.

Note: SSH tests are currently being skipped due to SAT-28933.

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9481
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ====== 17 failed, 4 passed, 7 skipped, 184 warnings in 876.48s (0:14:36) =======

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9602
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ===== 11 failed, 10 passed, 7 skipped, 190 warnings in 1040.88s (0:17:20) ======

@lhellebr lhellebr force-pushed the template_sync_proxy_ui branch from f4af0a6 to ea4fc79 Compare December 12, 2024 11:33
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9603
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ===== 11 failed, 10 passed, 7 skipped, 190 warnings in 1125.45s (0:18:45) ======

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

3 similar comments
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates
airgun: 1621

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9614
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ========== 12 passed, 16 skipped, 184 warnings in 1016.92s (0:16:56) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 13, 2024
@lhellebr
Copy link
Contributor Author

Hooray, this and the associated airgun PR can be merged

@lhellebr lhellebr requested a review from a team December 13, 2024 12:31
pnovotny
pnovotny approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnovotny pnovotny merged commit 6d0df0b into SatelliteQE:master Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnovotny pnovotny pnovotny approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@lhellebr lhellebr

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhellebr @Satellite-QE @pnovotny @pondrejk